Feat/cs/remove alloc#3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes TypedStreamDeserializer by removing redundant allocations, inlining hot functions, and replacing the HashSet cache with a Vec for tracking embedded types.
- Swapped
seen_embedded_types: HashSet<usize>for aVec<usize> - Added
#[inline(always)]to several small readers - Refactored
read_numberandread_typesto avoid cloning and reduce indirection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/deserializer/typedstream.rs | Replaced HashSet with Vec, inlined methods, and refactored number/type readers |
| src/deserializer/read.rs | Added #[inline(always)] to byte- and pointer-readers |
Comments suppressed due to low confidence (1)
src/deserializer/typedstream.rs:161
- The comment on
read_unsigned_intincorrectly says "signed integer"; it should reference "unsigned integer" to match the function's purpose.
/// Reads a signed integer from the stream, advancing the position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_types()seen_embedded_typescache